conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

Add uic and rcc entry points #178

Closed n-elie closed 1 year ago

n-elie commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

I remember we manually had to move scripts around for pyside2.

https://github.com/conda-forge/pyside2-feedstock/blob/main/recipe/build.sh#L94

hmaarrfk commented 1 year ago

I also noticed that the script did little other than to call

uic -g python

Most of the script tried to work around issues of finding the binary when shipped within python's virtual environments.

hmaarrfk commented 1 year ago

and our patch: https://github.com/conda-forge/pyside2-feedstock/blob/main/recipe/patches/pyside2-tools-obsolete.patch

n-elie commented 1 year ago

@hmaarrfk Thanks for the hints. I managed to get something working on linux and osx, but the build is failing for some reasons in windows and aarch64. These failures does not seem to be related to my modifications.

hmaarrfk commented 1 year ago

Does or "does not"?

n-elie commented 1 year ago

"does not", sorry

hmaarrfk commented 1 year ago

I typically verify by creating a mostly empty pull request and rerendering there. lets do that?

jschueller commented 1 year ago

Could you try rebase ? the clang pinning and patch should not be necessary anymore

n-elie commented 1 year ago

@jschueller I was trying to rebase but it seems you are working on it in #182

jschueller commented 1 year ago

yes, I included your work

n-elie commented 1 year ago

Great, thank you