Closed n-elie closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I remember we manually had to move scripts around for pyside2.
https://github.com/conda-forge/pyside2-feedstock/blob/main/recipe/build.sh#L94
I also noticed that the script did little other than to call
uic -g python
Most of the script tried to work around issues of finding the binary when shipped within python's virtual environments.
@hmaarrfk Thanks for the hints. I managed to get something working on linux and osx, but the build is failing for some reasons in windows and aarch64. These failures does not seem to be related to my modifications.
Does or "does not"?
"does not", sorry
I typically verify by creating a mostly empty pull request and rerendering there. lets do that?
Could you try rebase ? the clang pinning and patch should not be necessary anymore
@jschueller I was trying to rebase but it seems you are working on it in #182
yes, I included your work
Great, thank you
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)