conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

PySide6 - Fix clobber path with qt-main (qt5) #222

Closed hmaarrfk closed 4 months ago

hmaarrfk commented 4 months ago

Checklist

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 4 months ago

Windows might need "Library" in the patch somewhere, lets see what the CIs say.

hmaarrfk commented 4 months ago

sorry about this, I think the problem is that for some reason the uic file gets moved to bin and gets included.

I'll see if i can make an other PR.

./qt-main-5.15.8-h112747c_20/bin/uic
./pyside6-6.7.0-py310h7a3fa89_1/bin/uic
./qt6-main-6.7.0-h87a10bb_0/lib/qt6/ui

so clearly qt6-main uses it well, but the pyside6 exe moves it somehow???