conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

Avoid qt-main clobbering #234

Closed traversaro closed 1 month ago

traversaro commented 1 month ago

Fix and add tests for https://github.com/conda-forge/pyside2-feedstock/issues/223 .

Checklist

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

traversaro commented 1 month ago

Existing checks seems to be working fine thanks to https://github.com/conda-forge/pyside2-feedstock/pull/222, @hmaarrfk do you hae any additional test that you think it could make sense to add?

traversaro commented 1 month ago

@conda-forge-admin, please rerender

hmaarrfk commented 1 month ago

i know that it removes more just uic can you list out the binaries that we miss?

traversaro commented 1 month ago

i know that it removes more just uic can you list out the binaries that we miss?

The relevant code is https://github.com/pyside/pyside-setup/blob/dev/sources/pyside-tools/CMakeLists.txt#L35-L60 . All the tools that are skipped by the NO_QT_TOOLS actually come from the qt6 installation prefix, the precise list is:

On Apple platform, the directories:

while on non-Apple platform, also the following commands:

The NO_QT_TOOLS is used in mingw packaging (https://github.com/msys2/MINGW-packages/blob/3410183e8d0d2d3fe65313c0c3f4a7909df55889/mingw-w64-pyside6/PKGBUILD#L91), homebrew (https://github.com/Homebrew/homebrew-core/blob/2461efa1197635f5bd546536a7ace1c6b9ab3535/Formula/p/pyside.rb#L78) and archlinux (https://gitlab.archlinux.org/archlinux/packaging/packages/pyside6/-/blob/8f9efdc1531d6a9776c1d4b223564645c44bccf4/PKGBUILD#L63).

hmaarrfk commented 1 month ago

Alright thanks. Let’s go with this and see where it goes