Backport patch for 6.8.0 and add tests for future failures

conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.

BSD 3-Clause "New" or "Revised" License

17 stars 21 forks source link

Closed hmaarrfk closed 1 month ago

hmaarrfk commented 1 month ago

I thought that this would be a good test to add, it did have the desired effect, then I tried their patch and it seems ok.

conda-forge-admin commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 1 month ago

why not wait for 6.8.1?

its hard to "merge red", i could downgrade the version, but it was "just as easy" to try the upstream patch.

hmaarrfk commented 1 month ago

The nice thing is that upstream seems to have added a similar test to the one I added to their automation.

ccordoba12 commented 1 month ago

its hard to "merge red", i could downgrade the version, but it was "just as easy" to try the upstream patch.

Ok, I was just curious.

The nice thing is that upstream seems to have added a similar test to the one I added to their automation.

Finally! Haha

github-actions[bot] commented 1 month ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

hmaarrfk commented 1 month ago

For some reason the CIs didn't trigger.