search

conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

python3.8 needs to be patched #56

Closed looooo closed 4 years ago

looooo commented 4 years ago

regarding: https://bugreports.qt.io/browse/PYSIDE-939 py3.8 needs to be patched.

for example, the issues occur here: https://github.com/conda-forge/freecad-feedstock/pull/30

jschueller commented 4 years ago

I dont understand what need to be patched : the issue is mentionning a cpython commit that occured before the release, did it not get into the release ? otherwise pyside2 has no pending patch regarding that issue.

looooo commented 4 years ago

I guess there is nothing to do for pyside2. But for the py3.8 migration to continue we need to wait for a patched python3.8 if I understood it correctly.

hmaarrfk commented 4 years ago

also: https://bugreports.qt.io/browse/PYSIDE-1140

hmaarrfk commented 4 years ago

https://codereview.qt-project.org/c/pyside/pyside-setup/+/282705

looooo commented 4 years ago

@hmaarrfk should we wait for a new version or should we patch the current version?

hmaarrfk commented 4 years ago

I tried to patch it quickly on linux, it didn't fully pass. I figure we should just wait.

hmaarrfk commented 4 years ago

asking for a backport might be an option.

looooo commented 4 years ago

Regarding pyside2-gitter, we need to wait for python3.8.1 and once available have to build the 5.14 version of pyside2 to close this issue.

ref.: https://github.com/conda-forge/python-feedstock/issues/293

looooo commented 4 years ago

As pyside 5.14 seems to be not compatible with qt5.12 we need to backport the py3.8 fixes which were added to version 5.14.

hmaarrfk commented 4 years ago

Wanna try to go through the patching exercise. At least 2 patches seem necessary.

Maybe custom patching too

looooo commented 4 years ago

I tried to backport the necessary py3.8 commits and it seems this worked (at least for linux). If you want to test, I uploaded a package to channel freecad/label/testing.

https://github.com/conda-forge/pyside2-feedstock/pull/62