search

conda-forge / pyspharm-feedstock

A conda-smithy repository for pyspharm.
BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Rebuild for python311 #22

Closed regro-cf-autotick-bot closed 3 months ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3352041225, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

jakirkham commented 1 year ago

@conda-forge-admin, please re-render

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

xhochy commented 1 year ago

@conda-forge-admin please rerender

xhochy commented 1 year ago

Fails with

src/alf.f:273:22:

  273 |       call lfim1(init,theta,l,n,nm,id,pb,wlfim,wlfim(iw1),
      |                      1
Error: Rank mismatch in argument 'theta' at (1) (rank-1 and scalar)
src/alf.f:465:22:

  465 |       call lfin1(init,theta,l,m,nm,id,pb,wlfin,wlfin(iw1),
      |                      1
Error: Rank mismatch in argument 'theta' at (1) (rank-1 and scalar)
ocefpaf commented 1 year ago

I'm not sure this package is maintained. Don't hold any migrations b/c of this one.

zmoon commented 3 months ago

Seems like https://github.com/jswhit/pyspharm/commit/14a09f32762c8987201ae16e8d4da6af2c034a5a may have addressed the above issue, but they haven't done a release. But I suppose the commit and build number in the recipe could be updated.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

Documentation on acceptable licenses can be found here.

ocefpaf commented 3 months ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

Documentation on acceptable licenses can be found here.

ocefpaf commented 3 months ago

@conda-forge-admin, please rerender

zmoon commented 3 months ago

Well 3.11 worked. Could upper-bound NumPy until they get the Meson build fully working?

ocefpaf commented 3 months ago

Well 3.11 worked. Could upper-bound NumPy until they get the Meson build fully working?

I'm not sure we can make py3.12 with the min numpy available there. Maybe we need to upper bound python itself. Or did you try it? If so, which version of numpy worked for you?

zmoon commented 3 months ago

I'm not sure we can make py3.12 with the min numpy available there. Maybe we need to upper bound python itself. Or did you try it? If so, which version of numpy worked for you?

I suspected numpy <1.26 would also prevent 3.12, but more clear about the intent. But maybe both should be done. I didn't try it.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

Documentation on acceptable licenses can be found here.

ocefpaf commented 3 months ago

@conda-forge-admin, please rerender

ocefpaf commented 3 months ago

I suspected numpy <1.26 would also prevent 3.12, but more clear about the intent. But maybe both should be done. I didn't try it.

That would raise an unsolvable error instead. We need to revisit the py312 limit when a new version is out.

github-actions[bot] commented 3 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing, but could not be merged (error=API error in PUT to merge -- 'Resource not accessible by integration').

zmoon commented 3 months ago

That would raise an unsolvable error instead.

Even combined with the py312 skip? I guess it doesn't matter though.

ocefpaf commented 3 months ago

That would raise an unsolvable error instead.

Even combined with the py312 skip? I guess it doesn't matter though.

The thing is, it is not numpy, it is the unavailability of an earlier numpy on py312 in conda-forge. In that context, it is our implementation of py312 that is problem, hence, a py312 skip is to way to go. Sure, both are OK but maybe better yet would be a comment in the skip to remind us to remove it in case of an update (or even the unlikely case of an older numpy get built for py312). With all that said, it is not worth it now and I'd rather merge this and revisit this recipe when a new version is out. We also need to try to remove the Windows skips, etc.