Add pyterate test - Githubissues

conda-forge / pyspice-feedstock

A conda-smithy repository for pyspice.

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Add pyterate test #17

Closed FabriceSalvaire closed 4 years ago

FabriceSalvaire commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [66]
Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [66]

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

FabriceSalvaire commented 4 years ago

of course it fails because pyterate is not in conda-forge

FabriceSalvaire commented 4 years ago

examples are executed in a Jupyter kernel
catch exceptions and report failure
we could check plot against a ref, if it makes sense ???

FabriceSalvaire commented 4 years ago

cool it simulates but fail on astable !

FabriceSalvaire commented 4 years ago

LINUX: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=171155&view=logs&j=517fe804-fa30-5dc2-1413-330699242c05&t=c7d0fcb4-3a10-5b26-dfea-e879a93fc2ab

OSX: is a bigger disaster ... https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=171155&view=logs&j=a8dee1cf-d17f-5cb0-b53f-4a93dfdbfb0c&t=d9dbf137-9a7f-5666-c60c-9e1b2fc31445

FabriceSalvaire commented 4 years ago

WINDOWS: test %SRC_DIR%

OSX:

2020-06-05 19:41:31,732 - Pyterate.RstFactory.Evaluator.NodeEvaluator.Document - NodeEvaluator.INFO - 
From cffi callback <function NgSpiceShared._send_char at 0x1167104c0>:
Traceback (most recent call last):
  File "$PREFIX/lib/python3.8/site-packages/PySpice/Spice/NgSpice/Shared.py", line 512, in _send_char
    message = ffi_string_utf8(message_c)
  File "$PREFIX/lib/python3.8/site-packages/PySpice/Spice/NgSpice/Shared.py", line 86, in ffi_string_utf8
    return ffi.string(x).decode('utf8') # Fixme: ascii ?
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 47-48: invalid continuation byte

ngSpice_Circ returned 1

stuarteberg commented 4 years ago

In #19 you asked:

is it due to git clone on osx ?

Maybe. Let's eliminate that variable by using a tarball instead of git. I have pushed a fake tag to my own fork of PySpice, which will allow us to use a tarball source instead of git. Try this change:

https://github.com/stuarteberg/pyspice-feedstock/commit/e7a7bdee989ef6ca6c8c335960502584eaadcd47

FabriceSalvaire commented 4 years ago

@stuarteberg I will try that later

Summary:

astable.py fails on Linux
ngspice doesn't like the desk on OSX , only special char is °
Windows doesn't run pyterate for some reason ???

FabriceSalvaire commented 4 years ago

@conda-forge-admin, please rerender