search

conda-forge / pyspice-feedstock

A conda-smithy repository for pyspice.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Can we use post-link.bat to run pyspice-post-installation --install-ngspice-dll #9

Closed FabriceSalvaire closed 4 years ago

FabriceSalvaire commented 4 years ago

Is it still required ???

set SPICE64_DLL_DIR=%PREFIX%\lib\site-packages\PySpice\Spice\NgSpice\Spice64_dll
md %SPICE64_DLL_DIR%
cd %SPICE64_DLL_DIR%
mklink /d dll-vs ..\..\..\..\..\..\bin
stuarteberg commented 4 years ago

I don't think this is a good idea. The goal of conda-forge is to provide a full distribution, in which all dependencies of each package are provided by conda-forge (and compiled on their infrastructure). It would be highly unusual for a package to download one of its dependencies from an external source.

Now that conda-forge provides a package for ngspice (for Linux/Mac/Windows), there is no need to download it separately. Simply listing it as a dependency is sufficient to make sure it is installed. Adding a symlink in post-link.bat to help PySpice find it seems fine to me.

Have you detected any problems with the current pyspice/ngspice package combination on conda-forge? It passes the tests...

FabriceSalvaire commented 4 years ago

I missed conda-forge can compile a Windows binary ...

Thus it is fine excepted if there is specific issues with the conda-forge binary.

Will update doc.