search

conda-forge / pysr-feedstock

A conda-smithy repository for pysr.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Unpin numpy as a host-dependency #83

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

By having >= 1.14 in the host section, this disables our mechanism for building against the oldest supported numpy. This means the recipe will always pull in the newest numpy (currently 1.24), and by the way the numpy C API works, this means the all pysr builds need the newest numpy to run[^1].

Effectively, this turns >=1.14 into >=1.24 (soon 1.25), which is clearly not the intent. Please have a look at the relevant section in the knowledge base.

[^1]: numpy doesn't bump the relevant marker for every version, but almost.

MilesCranmer commented 1 year ago

Thanks. Just to confirm, I should leave the numpy pin in run as is?

Nevermind, I had forgotten the difference but just re-read the docs page.

h-vetinari commented 1 year ago

~Thanks. Just to confirm, I should leave the numpy pin in run as is?~

Nevermind, I had forgotten the difference but just re-read the docs page.

As the docs explain, you should use - {{ pin_compatible('numpy') }} in run (which I don't see in #85)