search

conda-forge / pysr-feedstock

A conda-smithy repository for pysr.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Do not ever store build artefacts on `main` #86

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

This pollutes our azure accounts (and storage allowance) for 2 years with useless stuff. It's fine for debugging a PR, but https://github.com/conda-forge/pysr-feedstock/commit/925d13211796c3a23db694585c3fa91599677b59 should have never been merged to main.

CC @ngam

ngam commented 1 year ago

Thanks for noting this @h-vetinari. There are too many instances where I left this on in conda-forge after debugging. I will start cleaning up soon.

Do you have any reference re the allowance? Has it become a problem yet? It’s only a matter of time with big packages… Also, I was under the impression the artifacts are only stored for ~60 (or less) days just like the logs

h-vetinari commented 1 year ago

Also, I was under the impression the artifacts are only stored for ~60 (or less) days just like the logs

That's just for PRs. Logs on main get persisted for 2 years. Checking the logs here, it seems that the artefacts already get deleted before that (not sure based on what mechanism and whether that changed recently - I've never seen what actually happens with artefact persistence on main; I'm just reflecting the clear instructions I've gotten about this, but details aside, it seems like a no-brainer to not store these things pointlessly)

ngam commented 1 year ago

but details aside, it seems like a no-brainer to not store these things pointlessly)

100% agree

MilesCranmer commented 1 year ago

Closed from #85