search

conda-forge / python-eccodes-feedstock

A conda-smithy repository for python-eccodes.
BSD 3-Clause "New" or "Revised" License
6 stars 16 forks source link

Version 2.3.0 #21

Closed kmuehlbauer closed 7 years ago

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

kmuehlbauer commented 7 years ago

@ocefpaf Although travis reports green, all builds have been terminated due to log-length according to the logs. This is also indicated by the short build times.

We need to implement those log-length fixes of yours. I can do this monday earliest.

ocefpaf commented 7 years ago

Probably. I can't look at the logs now (I'll on mobile most of the day. )

On Jun 10, 2017 3:28 AM, "Kai Mühlbauer" notifications@github.com wrote:

@ocefpaf https://github.com/ocefpaf Although travis reports green, all builds have been terminated due to log-length according to the logs. This is also indicated by the short build times.

We need to implement those log-length fixes of yours. I can do this monday earliest.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/conda-forge/python-eccodes-feedstock/pull/21#issuecomment-307546301, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6BLxInO0614vZ1LVpgJMBiuUP2kv8wks5sCjeIgaJpZM4N1yBf .

kynan commented 7 years ago

@kmuehlbauer the tests had already passed, the log stops somewhere in rewriting rpaths. This shouldn't prevent merging this, should it?

ocefpaf commented 7 years ago

The binary upload happens after that. The green CI there is misleading. We should not merge b/c that won't create the new version package.

kynan commented 7 years ago

Why would it not?

kmuehlbauer commented 7 years ago

Why would it not?

The section where the actual upload takes place wasn't run at all. So it seems from the log output. Let's see how the build does with the reduced log output.

kmuehlbauer commented 7 years ago

Now this worked just fine. Merging.

ocefpaf commented 7 years ago

Thanks for fixing it Kai!