search

conda-forge / python-eccodes-feedstock

A conda-smithy repository for python-eccodes.
BSD 3-Clause "New" or "Revised" License
6 stars 16 forks source link

python-eccodes 2.10.0 in beta? #43

Closed bjlittle closed 5 years ago

bjlittle commented 5 years ago

Just asking the obvious question here... so put me right or shoot me down, but isn't this python-eccodes version a beta release? From the ECMWF, see here and here.

If this is beta, then shouldn't the conda-forge version reflect this status to the Python community for clarity?

kmuehlbauer commented 5 years ago

According to semver this is no beta :grin: The question is, how should this be reflected here?

bjlittle commented 5 years ago

SemVer supports beta versions and so does pep440... So I'm not quite sure what you mean @kmuehlbauer

If the ECMWF say their package is in beta, shouldn't the version reflect that?

So 2.10.0-beta or 2.10b0 or however you choose following semver or pep440... whatever really.

My main point is should we honour the ECMWF public statement that their package is in beta release and reflect that in the current version here?

I just think that the community need clarity / awareness of this, and users are more likely to see the version change rather than read the ECMWF blog or release notes. So adding beta into the version seems to me to be a healthy and fair reflection of the release state of the package and underlying software.

Just sayin... thanks :smile:

kmuehlbauer commented 5 years ago

@bjlittle That's what I was writing. The released version is 2.10.0 and not 2.10.0-beta according to ECMWF.

I have no strong feelings either way, so what is the cf way of handling this, @ocefpaf?

ocefpaf commented 5 years ago

@bjlittle That's what I was writing. The released version is 2.10.0 and not 2.10.0-beta according to ECMWF.

I agree with @kmuehlbauer, the info is not in the version so it is not semver. (If we have to dig that kind of info from every release web page/email/announcement conda-forge would grind to a halt!)

I have no strong feelings either way, so what is the cf way of handling this, @ocefpaf?

We can fix that if the maintainers here up to it but I also don't have strong feelings about it. Whatever is easier is fine by me.

shahramn commented 5 years ago

Hi, Only the Python 3 support is beta. The rest has been fully tested and fit for operations.

Sent from my iPhone

On 8 Dec 2018, at 11:43, Filipe notifications@github.com<mailto:notifications@github.com> wrote:

@bjlittlehttps://github.com/bjlittle That's what I was writing. The released version is 2.10.0 and not 2.10.0-beta according to ECMWF.

I agree with @kmuehlbauerhttps://github.com/kmuehlbauer, the info is not in the version so it is not semver. (If we have to dig that kind of info from every release web page/email/announcement conda-forge would grind to a halt!)

I have no strong feelings either way, so what is the cf way of handling this, @ocefpafhttps://github.com/ocefpaf?

We can fix that if the maintainers here up to it but I also don't have strong feelings about it. What ever is easier is fine by me.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/conda-forge/python-eccodes-feedstock/issues/43#issuecomment-445453124, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXhy0wwmElI7kHT7Cu3vWqzyEezcVbjCks5u26X0gaJpZM4ZIu-4.

bjlittle commented 5 years ago

Thanks everyone for the discussion and the common sense clarification - it's really helpful!

I'm more than happy to close this (non-issue) issue, cheers :smile: