Add windows build - Githubissues

conda-forge / python-eccodes-feedstock

A conda-smithy repository for python-eccodes.

BSD 3-Clause "New" or "Revised" License

6 stars 16 forks source link

Add windows build #53

Closed dtip closed 4 years ago

dtip commented 4 years ago

Quick experiment to see if we can get an Windows build for python-eccodes.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dtip commented 4 years ago

We could try to enable the experimental fast bindings but that would make this doubly-experimental on Windows which may not be a good thing. We should probably remove the cffi dep on Windows if we're not compiling the bindings.

kmuehlbauer commented 4 years ago

@dtip Seems this is OK. I can merge, if you are happy with it.

dtip commented 4 years ago

@kmuehlbauer Yes please merge. We'll see if it actually works!

kmuehlbauer commented 4 years ago

@dtip Good to have you as maintainer here, welcome.

dtip commented 4 years ago

Thanks, Kai :)