search

conda-forge / python-feedstock

A conda-smithy repository for python.
BSD 3-Clause "New" or "Revised" License
46 stars 105 forks source link

PGO for windows python 3.8 build #278

Open mariusvniekerk opened 5 years ago

mariusvniekerk commented 5 years ago

As part of the python 3.8.0 release, we are not building windows with PGO due to the vs2017 base image missing certain key libraries.

We need to install Microsoft.VisualCpp.PGO.X64 into the vs2017 installation. This could also come from Microsoft.VisualStudio.Component.VC.DiagnosticTools or Microsoft.VisualStudio.Component.VC.Tools.x86.x64.

This issue is opened to ensure that at some point in the future we add this back.

jakirkham commented 5 years ago

Are these things we can install or do we need to ask Azure?

mariusvniekerk commented 5 years ago

we can theoretically install them by grabbing the web installer and running the modify cli this is probably pretty slow, but might work for now until we can convince Azure to add it.

jakirkham commented 5 years ago

Might be even easier to just ask at the Summit. 😉

mariusvniekerk commented 4 years ago

Tried to run the install for what we thought was the required package.

Turns out it was already there? cc @jjhelmus

See the following log for the details: dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/105965/logs/56

Red-Eyed commented 3 years ago

Hello all, I'm not a Windows specialist, but why python cannot be built with clang for windows?

Thanks!

isuruf commented 3 years ago

https://bugs.python.org/issue33351 Even if python can be built with clang on windows, this means that the static python library will be tied to clang and not msvc which we do not want.

hmaarrfk commented 2 years ago

We moved to VS2019 so maybe this effort can be revived with VisualStudio?