Update to Python 3.12.1

ismail commented 11 months ago

Refresh 0005-Unvendor-openssl.patch to apply

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ismail commented 11 months ago

@conda-forge-admin, please rerender

ismail commented 11 months ago

@conda-forge-admin, please rerender

ismail commented 11 months ago

macOS x86-64 builds fail with an ncurses related error

[...]/lib-dynload/_curses.cpython-312-darwin.so, 2): Symbol not found: _extended_color_content

Python has this check to see if it can use _extended_color_content (uninteresting parts omitted):

#if NCURSES_EXT_FUNCS+0 >= 20170401 && NCURSES_EXT_COLORS+0 >= 20170401
#define _NCURSES_EXTENDED_COLOR_FUNCS   1
#else
#define _NCURSES_EXTENDED_COLOR_FUNCS   0
#endif

#if _NCURSES_EXTENDED_COLOR_FUNCS
#define _CURSES_INIT_COLOR_FUNC         init_extended_color
#else
#define _CURSES_INIT_COLOR_FUNC         init_color
#endif  /* _NCURSES_EXTENDED_COLOR_FUNCS */

If I check ncurses package on macOS arm64:

❯ nm -g ./.pixi/env/lib/libncursesw.6.dylib | grep init_extended_color
0000000000009990 T _init_extended_color
0000000000009740 T _init_extended_color_sp

I downloaded the osx-64/ncurses-6.4-h93d8f39_1.conda to double check and sure enough symbol exists there too

❯ file ./lib/libncursesw.6.dylib
./lib/libncursesw.6.dylib: Mach-O 64-bit x86_64 dynamically linked shared library, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL>

❯ nm -g ./lib/libncursesw.6.dylib | grep init_extended_color
0000000000008160 T _init_extended_color
0000000000007eb0 T _init_extended_color_sp

Interestingly, _curses.cpython-312-darwin.so is linking to libncurses.6.dylib

❯ otool -L ./osx-arm64/lib/python3.12/lib-dynload/_curses.cpython-312-darwin.so
./osx-arm64/lib/python3.12/lib-dynload/_curses.cpython-312-darwin.so:
    @rpath/libncurses.6.dylib (compatibility version 6.0.0, current version 6.0.0)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.0.0)

which also should make arm64 test fail, but that's not happening.

ismail commented 11 months ago

Apparently until https://github.com/python/cpython/commit/d34650e7409b6a7cc64d7a118e4500c2f3cdbcf3 Python3 was not correctly detecting ncursesw on macOS, so this explains why this was not seen before.

ismail commented 11 months ago

Someone else, please feel free to pick this up.

I think building non-wide curses on macOS doesn't make sense, but it'd be too big of a hammer. We just need to make sure Python links to ncursesw on macOS.