search

conda-forge / python-feedstock

A conda-smithy repository for python.
BSD 3-Clause "New" or "Revised" License
46 stars 105 forks source link

Windows builds depend on xorg #720

Closed h-vetinari closed 1 month ago

h-vetinari commented 1 month ago

After some iteration in #706, we ended up porting variants of that to the various branches, e.g. https://github.com/conda-forge/python-feedstock/commit/3052d25823f4ef46b433e5400ef811ee337cd41d on main.

However, the run-export from xorg-libx11 doesn't seem to get ignored as specified https://github.com/conda-forge/python-feedstock/blob/f0d9be92d42c86c6fef19bb293d1dfce247a1d95/recipe/meta.yaml#L91-L95

on windows, leading to an xorg-libx11 >=1.8.9,<2.0a0 dependency for our windows builds.

Presumably we should add a selector to https://github.com/conda-forge/python-feedstock/blob/f0d9be92d42c86c6fef19bb293d1dfce247a1d95/recipe/meta.yaml#L171-L172

(and maybe raise a conda-build issue)

CC @isuruf

h-vetinari commented 1 month ago

Ah, I see the issue. ignore_run_exports_from: has a selector 🤦

isuruf commented 1 month ago

Thanks for the PR. Keeping this open until backports are in.

h-vetinari commented 1 month ago