do not omit frame pointer on Linux

conda-forge / python-feedstock

A conda-smithy repository for python.

BSD 3-Clause "New" or "Revised" License

46 stars 105 forks source link

do not omit frame pointer on Linux #740

Open matthiasdiener opened 2 weeks ago

matthiasdiener commented 2 weeks ago

Addresses #688.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-admin commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

matthiasdiener commented 2 weeks ago

This is ready for review. A bit more context for not omitting the frame pointer: https://fedoraproject.org/wiki/Changes/fno-omit-frame-pointer

xhochy commented 2 weeks ago

I'm generally in favor of it but asking myself whether we should set this globally in the compiler activation?

matthiasdiener commented 2 weeks ago

I'm generally in favor of it but asking myself whether we should set this globally in the compiler activation?

FWIW, I'd be in favor of this as a (longer-term?) goal. In the meantime, would it make sense to add this flag just to this feedstock (at least for Python 3.12+)?