search

conda-forge / python-graphviz-feedstock

A conda-smithy repository for python-graphviz.
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

RFC: Use noarch #12

Closed jakirkham closed 5 years ago

jakirkham commented 6 years ago

Switch the recipe over to noarch Python. Also always apply the Windows patch so as to allow for the noarch Python build.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

Could you please take a look @xflr6? Would like to hear what you think. 😄

xflr6 commented 6 years ago

Thanks. Applying the patch with the Windows branch everywhere for a platform-agnostic conda package seems good to me (do not know much about the build tool used here though). AFAICT, the build for this PR currently still fails:

Applying patch: '/recipe_root/windows-bat.patch'
patching file graphviz/backend.py
Hunk #1 FAILED at 85.
1 out of 1 hunk FAILED -- saving rejects to file graphviz/backend.py.rej

I suspect there is still the issue of how to patch a file with CRLF line endings within conda-build (see conda/conda-build#1973): On the windows-specific branch there is currently some trial and error to get this working (I would prefer if one could just have the option to configure patch --binary as proposed in issue 1973 mentioned above, e.g. by having a special ending):

https://github.com/conda/conda-build/blob/de49f28806a20e251ad0a54c3ae4da0c49dd0a1d/conda_build/source.py#L563-L595

jakirkham commented 6 years ago

Tried to manually apply the patch, but it ran into some issues.

jakirkham commented 5 years ago

Replacing with PR ( https://github.com/conda-forge/python-graphviz-feedstock/pull/23 ).