Closed ccordoba12 closed 7 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Feel free to add yourself as a maintainer as well, @ccordoba12.
Feel free to add yourself as a maintainer as well, @ccordoba12.
Ok
Is there a good way to test this change?
I'll add a test and re-render in a couple of days. I don't have more time to work on this right now :-)
That's fine. I'll take on the re-render. Just think about a test when you have some time.
Was about to upgrade to 0.6 in PR ( https://github.com/conda-forge/python-graphviz-feedstock/pull/4 ), but noticed this PR was still here. Broke out a re-rendering in PR ( https://github.com/conda-forge/python-graphviz-feedstock/pull/5 ), which has been merged. Also have rebased the 0.6 release PR so it is ready to go. Not sure if we still want to finish this up first or if we should go ahead with the 0.6 release and follow up on this afterwards. Please let me know what you think, @ccordoba12.
@jakirkham, I added a test based on dask
because @mrocklin provided me with it. I really don't know how to use python-graphviz
and don't have time to come up with a simpler test, so I hope you're fine with it.
Besides, one of the main users of python-graphviz
among the scientific stack is dask
, so I think it's good to use it as a test here.
Everything is green now, so I think this should be merged.
I have no qualms with the test, @ccordoba12. Though it would be nice if @xflr6 took a look (particularly at the patch).
Yep, I saw he did another PR but it's failing. I mentioned there the reasons why I think that's happening.
Closing in favor of #6.
This is needed because Graphviz binaries (e.g.
dot
) are redefined as batch scripts in the Graphviz conda-forge package. Hence, it doesn't make sense to submit this patch upstream.