Patch 0.16 for windows - Githubissues

conda-forge / python-graphviz-feedstock

A conda-smithy repository for python-graphviz.

BSD 3-Clause "New" or "Revised" License

3 stars 12 forks source link

Patch 0.16 for windows #43

Closed rwedge closed 3 years ago

rwedge commented 3 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Fixes #42

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

rwedge commented 3 years ago

Ready for review.

I tested the change on windows by using the build-locally.py script and installing the build artifact on a windows vm.

I tried testing via CI by removing the noarch: python flag but it was unable to build the package on windows due to the patch package not being avaiable for windows

rwedge commented 3 years ago

@scopatz @jakirkham ready for review