conda-forge / python-graphviz-feedstock

A conda-smithy repository for python-graphviz.
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Drop windows patch #44

Closed jsignell closed 3 years ago

jsignell commented 3 years ago

Checklist

https://github.com/conda-forge/graphviz-feedstock/pull/59 https://github.com/dask/dask/issues/7231

@jakirkham

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

jsignell commented 3 years ago

@conda-forge-admin, please rerender

jakirkham commented 3 years ago

Thanks Julia! 😄

Could we also add a version requirement to graphviz to ensure it is 2.46.1 or greater? Want to make sure we are only using graphviz packages with the changes in PR ( https://github.com/conda-forge/graphviz-feedstock/pull/59 )

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 3 years ago

@conda-forge-admin, please re-render.

jakirkham commented 3 years ago

Thanks Julia! 😄

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 3 years ago

cc @xflr6 (for awareness)