search

conda-forge / python-graphviz-feedstock

A conda-smithy repository for python-graphviz.
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

add fix to support conda-forge Graphviz binaries under windows #6

Closed xflr6 closed 7 years ago

xflr6 commented 7 years ago

As a replacement of #2

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ccordoba12 commented 7 years ago

I think this one should be closed in favor of #2, which I updated and it's working as expected.

jakirkham commented 7 years ago

Could you try adding the same test that @ccordoba12 added in his PR, @xflr6? I think that would provide useful insight for this discussion.

xflr6 commented 7 years ago

Sure, done.

ccordoba12 commented 7 years ago

@jakirkham, please merge, this one is ready.

jakirkham commented 7 years ago

Thanks for adding the test @xflr6. Sounds good, @ccordoba12, will do.

There are few changes here that are unrelated to the primary content and are undesirable IMHO. Have asked that those changes be removed. Once addressed would be happy to merge.

jakirkham commented 7 years ago

Thanks @xflr6 and @ccordoba12 for both the changes and healthy discussion.

xflr6 commented 7 years ago

Thanks (also for the info about GitHub archive files). I just retried patching the PyPI files locally and it seemed to work (so maybe the issue I had originally was something else): Would be nice, if you get it to work with them.

ccordoba12 commented 7 years ago

Great to see this finally merged!