conda-forge / python-igraph-feedstock

A conda-smithy repository for python-igraph.
BSD 3-Clause "New" or "Revised" License
4 stars 11 forks source link

Add a patch to disable graph 70 in graph atlas tests #53

Closed xylar closed 2 years ago

xylar commented 2 years ago

This test seems to cause arbitrary failures.

Add xylar as a maintainer

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

The lack of a python 3.10 for linux-64 is causing me trouble downstream: https://github.com/conda-forge/mpas_tools-feedstock/pull/52

xylar commented 2 years ago

@sodre and @vtraag, this seems to be working (2 more tests still to go as I write this). Obviously, hard to be sure since the previous failures appear to have been pretty random. Let me know if you are okay with the patch approach or if you'd prefer something else.

vtraag commented 2 years ago

Great, looks good to me @xylar! Thanks for being willing to also help maintain this feedstock.

xylar commented 2 years ago

@vtraag, shoot! We're still seeing exactly the same error as before in some builds after this got merged:

FAIL: testHubScore (tests.test_atlas.GraphAtlasTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/python-igraph_1638450958889/test_tmp/tests/test_atlas.py", line 106, in testHubScore
    sc = g.hub_score()
igraph._igraph.InternalError: Error at src/linalg/arpack.c:1006: ARPACK error. -- No shifts could be applied during a cycle of the Implicitly restarted Arnoldi iteration. One possibility is to increase the size of NCV relative to NEV

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/python-igraph_1638450958889/test_tmp/tests/test_atlas.py", line 108, in testHubScore
    self.assertTrue(
AssertionError: False is not true : Hub score calculation threw exception for graph #70: Error at src/linalg/arpack.c:1006: ARPACK error. -- No shifts could be applied during a cycle of the Implicitly restarted Arnoldi iteration. One possibility is to increase the size of NCV relative to NEV

It's still referring to graph #70 even though I thought I assigned that one to the list to be skipped. Any idea why it didn't work?

xylar commented 2 years ago

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=421362&view=logs&jobId=bb1c2637-64c6-57bd-9ea6-93823b2df951&j=bb1c2637-64c6-57bd-9ea6-93823b2df951&t=350df31b-3291-5209-0bb7-031395f0baa1

xylar commented 2 years ago

I'm manually re-running the 2 failed tests but a better fix is still needed.

vtraag commented 2 years ago

Hmm, annoying, I would in principle expect it to work indeed. I don't have an idea directly, I'd need to check it out in more detail.

vtraag commented 2 years ago

Ah, it's already clear, it's not being handled for Hubs, I'll correct it and push it shortly.