conda-forge / pythonocc-core-feedstock

A conda-smithy repository for pythonocc-core.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Add support for OCCT variants novtk/all #23

Closed Krande closed 12 months ago

Krande commented 1 year ago

This PR adds support for occt variants (all & novtk). The latter is convenient when you need fewest possible package dependencies and you are not relying on any VTK features compiled in occt.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

Krande commented 1 year ago

@conda-forge-admin, please rerender

Krande commented 1 year ago

@tpaviot On my end http://pythonocc.org redirects to "https://serp.ai/python-courses/".

Does that happen to you too? Might I suggest we change the "home" link to https://github.com/tpaviot/pythonocc-core in the meta.yaml "about" section?

about:
  home: http://www.pythonocc.org/ -> https://github.com/tpaviot/pythonocc-core
tpaviot commented 1 year ago

@tpaviot On my end http://pythonocc.org redirects to "https://serp.ai/python-courses/".

Does that happen to you too? Might I suggest we change the "home" link to https://github.com/tpaviot/pythonocc-core in the meta.yaml "about" section?

about:
  home: http://www.pythonocc.org/ -> https://github.com/tpaviot/pythonocc-core

Yes, home points to pythonocc-core gh page

Krande commented 1 year ago

@looooo Let me know if you have any thoughts on this? And if you agree, I think this should be ready for merging :)

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo commented 1 year ago

Thanks @Krande, I think it's fine to merge this.