search

conda-forge / pythran-feedstock

A conda-smithy repository for pythran.
BSD 3-Clause "New" or "Revised" License
1 stars 11 forks source link

Pin xsimd version #60

Closed serge-sans-paille closed 3 years ago

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

serge-sans-paille commented 3 years ago

The travis error seems to be unrelated (?) cc @h-vetinari

h-vetinari commented 3 years ago

Yeah, travis is not doing well, see https://github.com/conda-forge/conda-forge.github.io/issues/1521.

Best thing to do would be to apply the following (and rerender):

diff --git a/conda-forge.yml b/conda-forge.yml
index 9b5f040..e758699 100644
--- a/conda-forge.yml
+++ b/conda-forge.yml
@@ -1,4 +1,4 @@
 build_platform: {osx_arm64: osx_64}
 conda_forge_output_validation: true
-provider: {linux_aarch64: default, linux_ppc64le: default, win: azure}
+provider: {linux_aarch64: default, linux_ppc64le: azure, win: azure}
 test_on_native_only: true
h-vetinari commented 3 years ago

I'm preparing a repodata patch so that the already published builds are unbroken as well. How far back should we pin xsimd (and to which version)?

h-vetinari commented 3 years ago

Comparing the dates from the upstream xsimd-bundling & releases, I would come up with (edited)

Could you confirm or amend this please?

h-vetinari commented 3 years ago

Actually, I don't think we can pin to any xsimd version before 7.5.0, because there are no ppc builds before that, see here

serge-sans-paille commented 3 years ago

Message edited with the right versions.

h-vetinari commented 3 years ago

@serge-sans-paille

Message edited with the right versions.

Thanks! You're proposing 7.6.* for 0.10.0 in https://github.com/conda-forge/pythran-feedstock/pull/60/commits/91c5212f6cc458c44ec2ed1ccda18aa879a65f73 however - which one should it be? Also, as I said, we can only use xsimd 7.5.0 on ppc/aarch, because no earlier builds exist for those platforms. I guess it shouldn't be a problem?

h-vetinari commented 3 years ago

Ping @serge-sans-paille

h-vetinari commented 3 years ago

@serge-sans-paille Actually, I meant my question about xsimd 7.6. (this PR) vs xsimd 7.5. (your edit) vs. earlier xsimd-versions not being available for aarch/pcc.

In short, I'd still like to solve https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/174 so that scipy can be built again.

serge-sans-paille commented 3 years ago

I think both version are ok, even if I haven't tested with 7.6. It's the version that was used on Fedora and everything was fine. So basically: pick either of those (which is why I finally merged)