conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.
BSD 3-Clause "New" or "Revised" License
17 stars 43 forks source link

Only osx - libprotobuf4233_libgrpc156 #183

Closed hmaarrfk closed 1 year ago

hmaarrfk commented 1 year ago

Trying to debug a failure that historically occurs at:

  [3478/4743] cd /Users/runner/miniforge3/conda-bld/pytorch-recipe_1692633544754/work/build/third_party/onnx && /Users/runner/miniforge3/conda-bld/pytorch-recipe_1692633544754/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/bin/python /Users/runner/miniforge3/conda-bld/pytorch-recipe_1692633544754/work/third_party/onnx/onnx/gen_proto.py -p onnx_torch -o /Users/runner/miniforge3/conda-bld/pytorch-recipe_1692633544754/work/build/third_party/onnx/onnx onnx -m

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

I need a local x86 mac to troubleshoot this better.

Essentially, we need to tell protoc to use the BUILD_PREFIX protoc during cross compilation, not the HOST one.

maybe i can troubleshoot using arm + linux

h-vetinari commented 1 year ago

That should be a common problem with a common solution though? We set protobuf to the build prefix for osx-arm all over the place. There's also a dedicated cmake variable for that.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

Ok, so "debugging" this build on my little machine is really tiring, but I'm finding some locations in cmake that we can likely modify:

${PREFIX}/lib/cmake/protobuf/protobuf-targets-release.cmake
# Import target "protobuf::protoc" for configuration "Release"
set_property(TARGET protobuf::protoc APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(protobuf::protoc PROPERTIES
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/bin/protoc-23.3.0"
  )
list(APPEND _cmake_import_check_targets protobuf::protoc )
list(APPEND _cmake_import_check_files_for_protobuf::protoc "${_IMPORT_PREFIX}/bin/protoc-23.3.0" )

we cna likely change the locations of the specific protoc commands.

hmaarrfk commented 1 year ago

seems like we got through it. fingers crossed we get to the end.