search

conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.
BSD 3-Clause "New" or "Revised" License
17 stars 43 forks source link

Rebuild for libprotobuf 4.25.3 #225

Closed regro-cf-autotick-bot closed 6 months ago

regro-cf-autotick-bot commented 6 months ago

This PR has been triggered in an effort to update libgrpc162_libprotobuf4253.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8209444027, please use this URL for debugging.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

jakirkham commented 6 months ago

@hmaarrfk when you have a moment, could you please push a commit here so we can run CI?

hmaarrfk commented 6 months ago

I'm not personally very excited about 4.25.3. I know its selfish, but my sanity has really suffered due to tensorflow: https://github.com/conda-forge/tensorflow-feedstock/issues/378

I would also like to spend some time to help @njzjz in https://github.com/conda-forge/pytorch-cpu-feedstock/pull/224 before doing more migrations, unless he needs the 4.25.3 migration.

h-vetinari commented 6 months ago

We should focus on https://github.com/conda-forge/pytorch-cpu-feedstock/pull/221 - aside from including the version bump, that PR is passing, aside from running out of memory with the MKL version - there's no reason to expect that this PR will fare any differently (but it would be an easy follow-up to #221).

Tensorflow is a harder question, but I think switching to cirun and getting that off the ground should make things easier (though a substantial chunk of work until then).

jakirkham commented 6 months ago

Ok sorry I may not be as plugged into the different migrations happening here and TensorFlow. Happy to defer to your judgement

As to PyTorch CUDA ARM builds, think that is ready given we have decided to punt on CUDA 11 for the moment. So maybe we should just add a skip and push it through?

regro-cf-autotick-bot commented 6 months ago

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/8419408624