Feat/windows ci runner - Githubissues

conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.

BSD 3-Clause "New" or "Revised" License

17 stars 43 forks source link

Feat/windows ci runner #242

Closed wolfv closed 2 months ago

wolfv commented 3 months ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

aktech commented 3 months ago

Thanks for creating this I was just about to work on creating this one.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [110, 111, 149, 220, 221, 258]

For recipe:

It looks like the 'libtorch' output doesn't have any tests.

wolfv commented 3 months ago

Sure thing! Rebasing was actually a bit painful :)

Any idea why cirun is failing? Did I use the wrong label?

aktech commented 3 months ago

The error is: No runners configuration found after labels filtering

The workflow is requesting labels: x64, cirun-azure-windows-2xlarge, windows. The x64 is missing from here: https://github.com/conda-forge/.cirun/blob/b2aeabf22170179a4eb17f3f3c1e4eb45580e142/.cirun.global.yml#L127 I've just created a PR now: https://github.com/conda-forge/.cirun/pull/15

wolfv commented 3 months ago

Great. Should I push an empty commit to trigger?

aktech commented 3 months ago

Yes, that should work.

wolfv commented 3 months ago

Alright, I triggered!

wolfv commented 3 months ago

still not starting, any ideas @aktech ? :)

aktech commented 3 months ago

Yep, investigating

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [110, 111, 149, 220, 221, 258]
There are too few lines. There should be one empty line at the end of the file.

For recipe:

It looks like the 'libtorch' output doesn't have any tests.

hmaarrfk commented 3 months ago

sorry again for the conflicts.

baszalmstra commented 2 months ago

I incorporated all you changes in #231 I think we can close this.