Closed hmaarrfk closed 1 month ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
This seems to work. I’m trying 11.8 locally with Isuru’s patch for libpytorch
after that I’ll push here for the CIs to build the whole matrix.
@jeongseok-meta I think i got the changes that you requested for libpytorch
.
cc: @h-vetinari @isuruf for an other set of eyes. If all is green I hope to merge on friday. LMK
@hmaarrfk Awesome, thank you for sorting the issue out!
alright, lets merge so we can take some of the heat on friday.
Great! Do we still need https://github.com/conda-forge/pytorch-cpu-feedstock/pull/246, as I see that the changes are already included in this PR?
We will have to start a pytorch 2.4.0 migration tomorrow, so it may take a day or 3 for all the changes to propogate if you have dependnecies that depend on pytorch
Sorry I missed the ping, and thanks for fixing this!
happy to help!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)