conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.
BSD 3-Clause "New" or "Revised" License
17 stars 43 forks source link

Update to 2.4.0 and add libpytorch.so to lib location #250

Closed hmaarrfk closed 1 month ago

hmaarrfk commented 1 month ago

Checklist

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 1 month ago

This seems to work. I’m trying 11.8 locally with Isuru’s patch for libpytorch

after that I’ll push here for the CIs to build the whole matrix.

hmaarrfk commented 1 month ago

@jeongseok-meta I think i got the changes that you requested for libpytorch.

cc: @h-vetinari @isuruf for an other set of eyes. If all is green I hope to merge on friday. LMK

jeongseok-meta commented 1 month ago

@hmaarrfk Awesome, thank you for sorting the issue out!

hmaarrfk commented 1 month ago

alright, lets merge so we can take some of the heat on friday.

jeongseok-meta commented 1 month ago

Great! Do we still need https://github.com/conda-forge/pytorch-cpu-feedstock/pull/246, as I see that the changes are already included in this PR?

hmaarrfk commented 1 month ago

We will have to start a pytorch 2.4.0 migration tomorrow, so it may take a day or 3 for all the changes to propogate if you have dependnecies that depend on pytorch

h-vetinari commented 1 month ago

Sorry I missed the ping, and thanks for fixing this!

hmaarrfk commented 1 month ago

happy to help!