search

conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.
BSD 3-Clause "New" or "Revised" License
18 stars 50 forks source link

Rebuilt pytorch for MKL + numpy detection #252

Closed conda-forge-admin closed 2 months ago

conda-forge-admin commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #251.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 2 months ago

I think it has to do with cmake's new addition which kinda broke things for us.

The previous build had used cmake 3.29.5 on osx-64 and that patch was introduced in 3.30.0

hmaarrfk commented 2 months ago

@conda-forge-admin please rerender

hmaarrfk commented 2 months ago

Main:

2024-08-23T01:46:55.9080660Z   --   USE_MPS               : ON
2024-08-23T01:46:55.9080910Z   --   USE_MKL               : ON
2024-08-23T01:46:55.9081170Z   --   USE_MKLDNN            : ON
2024-08-23T01:46:55.9081440Z   --   USE_MKLDNN_ACL        : OFF
2024-08-23T01:46:55.9081730Z   --   USE_MKLDNN_CBLAS      : OFF
2024-08-23T01:46:55.9085040Z   --   USE_UCC               : OFF
2024-08-23T01:46:55.9085700Z   --   USE_ITT               : 0
2024-08-23T01:46:55.9087340Z   --   USE_NCCL              : OFF
2024-08-23T01:46:55.9087750Z   --   USE_NNPACK            : ON
2024-08-23T01:46:55.9088030Z   --   USE_NUMPY             : OFF

This PR:

2024-08-24T18:03:22.7211550Z   --   USE_MPS               : ON
2024-08-24T18:03:22.7211840Z   --   USE_MKL               :
2024-08-24T18:03:22.7212240Z   --   USE_MKLDNN            : ON
2024-08-24T18:03:22.7212560Z   --   USE_MKLDNN_ACL        : OFF
2024-08-24T18:03:22.7212990Z   --   USE_MKLDNN_CBLAS      : OFF
2024-08-24T18:03:22.7213620Z   --   USE_UCC               : OFF
2024-08-24T18:03:22.7213920Z   --   USE_ITT               : 0
2024-08-24T18:03:22.7214320Z   --   USE_NCCL              : OFF
2024-08-24T18:03:22.7214630Z   --   USE_NNPACK            : ON
2024-08-24T18:03:22.7215040Z   --   USE_NUMPY             : ON
hmaarrfk commented 2 months ago

ok here goes a full 20 hour build cycle. I guess we only need to wait 13 hours, that is GPU builds + OSX on main.

hmaarrfk commented 2 months ago

I'm going to ask for foregiveness so i can work on some of the migration tomorrow.