search

conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.
BSD 3-Clause "New" or "Revised" License
18 stars 50 forks source link

Rebuild for libabseil 20240722, libgrp 1.65 & libprotobuf 5.27.5 #265

Closed regro-cf-autotick-bot closed 1 month ago

regro-cf-autotick-bot commented 1 month ago

This PR has been triggered in an effort to update libabseil20240722_grpc165_libprotobuf5275.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-admin commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-admin commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 1 month ago

Hmmm. Well at least we don’t have to patch the C source code too much!!!

just our megabuild

h-vetinari commented 1 month ago

What would we have to patch in the megabuild? It should work exactly as before, and if osx compiles fine against the new version, chances are good that linux works as well, no?

hmaarrfk commented 1 month ago

I’m not sure what is different tbh. I still need to investigate. Or to change strategies.

hmaarrfk commented 1 month ago

osx compiles fine against the new version, chances are good that linux works as well, no?

ps. i haven't tested OSX, just linux on azure.

hmaarrfk commented 1 month ago

@conda-forge-admin please rerender

hmaarrfk commented 1 month ago

TODO: link with cusparselt https://github.com/conda-forge/cusparselt-feedstock/blob/main/recipe/meta.yaml

hmaarrfk commented 1 month ago

I'm going to rebuild the megabuild locally and upload the CMakeCache.txt and CMakeCache.txt.orig

hmaarrfk commented 1 month ago

Um.... the fat build was just fine on the CIs and locally....

{
  "linux-64/pytorch-2.4.1-cpu_generic_py310hca11fdf_1.conda": true,
  "linux-64/pytorch-2.4.1-cpu_generic_py313h430b9ab_1.conda": true,
  "linux-64/pytorch-2.4.1-cpu_generic_py311hc820e91_1.conda": true,
  "linux-64/pytorch-cpu-2.4.1-cpu_generic_py39h7a53447_1.conda": true,
  "linux-64/libtorch-2.4.1-cpu_generic_h5294bb1_1.conda": true,
  "linux-64/pytorch-2.4.1-cpu_generic_py312hd7281ff_1.conda": true,
  "linux-64/pytorch-2.4.1-cpu_generic_py39h0d0f2ad_1.conda": true
}

maybe a transient error like before....

hmaarrfk commented 1 month ago

one more check for cuda11/12 + absl

hmaarrfk commented 1 month ago

@conda-forge-admin please rerender