Open ZzEeKkAa opened 1 week ago
conda-forge-admin
commented
1 week ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
mgorny
commented
1 week ago In #289, I've started working on unvendoring oneDNN. We'd probably have to coordinate somehow to adjust oneDNN for XPU support too.
ZzEeKkAa
commented
1 week ago In #289, I've started working on unvendoring oneDNN. We'd probably have to coordinate somehow to adjust oneDNN for XPU support too.
Yes, it will be nice. I guess the only issue I have right now is with onednn. May be your PR will help. Did you see something like this:
[7/13] /usr/bin/ccache /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_build_env/bin/x86_64-conda-linux-gnu-g++ -DFLASHATTENTION_DISABLE_ALIBI -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTORCH_XPU_BUILD_MAIN_LIB -DUSE_EXTERNAL_MZCRC -DUSE_XPU -D_FILE_OFFSET_BITS=64 -Dtorch_xpu_EXPORTS -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/onnx -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/third_party/onnx -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/nlohmann -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/detail -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/ideep/mkl-dnn/include -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/xpu -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/torch/csrc/api -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/torch/csrc/api/include -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/caffe2/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/.. -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/miniz-2.1.0 -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/c10/xpu/../.. -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/c10/.. -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/third_party/gloo -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/gloo -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/tensorpipe/third_party/libuv/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/XNNPACK/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/eigen -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/INTERFACE -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/nlohmann/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/torch-xpu-ops/src -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env/include/sycl -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env/include -fdebug-prefix-map=/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work=/usr/local/src/conda/libtorch-2.5.1 -fdebug-prefix-map=/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env=/usr/local/src/conda-prefix -Wno-deprecated-declarations -Wno-error=maybe-uninitialized -D_GLIBCXX_USE_CXX11_ABI=1 -fvisibility-inlines-hidden -D__INTEL_PREVIEW_BREAKING_CHANGES -DUSE_PTHREADPOOL -DNDEBUG -DUSE_FBGEMM -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=range-loop-construct -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -DUSE_XPU -Wno-stringop-overflow -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION -O3 -DNDEBUG -DNDEBUG -std=gnu++17 -fPIC -DMKL_HAS_SBGEMM -DMKL_HAS_SHGEMM -DTORCH_USE_LIBUV -DCAFFE2_USE_GLOO -Wall -Wextra -Wdeprecated -Wno-unused-parameter -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-strict-overflow -Wno-strict-aliasing -Wunused-function -Wunused-variable -Wunused-but-set-variable -Wno-maybe-uninitialized -fvisibility=hidden -O2 -MD -MT caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o -MF caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o.d -o caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o -c /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/Blas.cpp
FAILED: caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o
/usr/bin/ccache /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_build_env/bin/x86_64-conda-linux-gnu-g++ -DFLASHATTENTION_DISABLE_ALIBI -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTORCH_XPU_BUILD_MAIN_LIB -DUSE_EXTERNAL_MZCRC -DUSE_XPU -D_FILE_OFFSET_BITS=64 -Dtorch_xpu_EXPORTS -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/onnx -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/third_party/onnx -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/nlohmann -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/detail -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/ideep/mkl-dnn/include -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/xpu -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/torch/csrc/api -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/torch/csrc/api/include -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/caffe2/aten/src -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/.. -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/miniz-2.1.0 -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/c10/xpu/../.. -I/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/c10/.. -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/build/third_party/gloo -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/gloo -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/tensorpipe/third_party/libuv/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/XNNPACK/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/cmake/../third_party/eigen -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/INTERFACE -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/nlohmann/include -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/torch-xpu-ops/src -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env/include/sycl -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env/include -fdebug-prefix-map=/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work=/usr/local/src/conda/libtorch-2.5.1 -fdebug-prefix-map=/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/_h_env=/usr/local/src/conda-prefix -Wno-deprecated-declarations -Wno-error=maybe-uninitialized -D_GLIBCXX_USE_CXX11_ABI=1 -fvisibility-inlines-hidden -D__INTEL_PREVIEW_BREAKING_CHANGES -DUSE_PTHREADPOOL -DNDEBUG -DUSE_FBGEMM -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=range-loop-construct -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -DUSE_XPU -Wno-stringop-overflow -DHAVE_AVX512_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION -O3 -DNDEBUG -DNDEBUG -std=gnu++17 -fPIC -DMKL_HAS_SBGEMM -DMKL_HAS_SHGEMM -DTORCH_USE_LIBUV -DCAFFE2_USE_GLOO -Wall -Wextra -Wdeprecated -Wno-unused-parameter -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-strict-overflow -Wno-strict-aliasing -Wunused-function -Wunused-variable -Wunused-but-set-variable -Wno-maybe-uninitialized -fvisibility=hidden -O2 -MD -MT caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o -MF caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o.d -o caffe2/CMakeFiles/torch_xpu.dir/__/aten/src/ATen/native/mkldnn/xpu/Blas.cpp.o -c /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/Blas.cpp
In file included from /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/detail/oneDNNContext.h:9,
from /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/detail/oneDNN.h:4,
from /home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/aten/src/ATen/native/mkldnn/xpu/Blas.cpp:4:
/home/jovyan/.miniforge3/conda-bld/debug_1731522437295/work/third_party/ideep/mkl-dnn/include/oneapi/dnnl/dnnl.hpp:23:10: fatal error: oneapi/dnnl/dnnl_config.h: No such file or directory
23 | #include "oneapi/dnnl/dnnl_config.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
error: subprocess-exited-with-error
No, I didn't — but I don't think our oneDNN package right now supports XPU at all. It's possible that adding XPU support will resolve this.
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Blocked by https://github.com/conda-forge/conda-smithy/issues/2129
Add xpu (aka intel gpu) support for pytorch.