Re-enable kineto submodule

conda-forge / pytorch-cpu-feedstock

A conda-smithy repository for pytorch-cpu.

BSD 3-Clause "New" or "Revised" License

17 stars 43 forks source link

Re-enable kineto submodule #76

Open h-vetinari opened 2 years ago

h-vetinari commented 2 years ago

Pytorch has a "first party submodule" called kineto under third_party/ (side note: holy maccaroni, that folder is a packager's nightmare 😅).

Trying to build torchaudio, I'm seeing the following warning:

  CMake Warning at [...]/lib/python3.8/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
    static library kineto_LIBRARY-NOTFOUND not found.

Any reason we shouldn't be compiling this here? Or just not done yet (out of that bucketful of submodules)...?

hmaarrfk commented 2 years ago

ripping apart a projects internal build system is hard and we just haven't had time for it.

help on this one would be appreciated.

i would start with the version pytorch uses in 1.10

hmaarrfk commented 2 years ago

did you ever get around building a kineto library?

h-vetinari commented 2 years ago

No, sorry. I guess we can add that to the list in #108...?

h-vetinari commented 1 year ago

So I wanted to open a new issue, but it seems it ended up getting enabled by default sometime, which ended up causing issues, and then promptly got disabled.

Now that cupti is packaged separately in conda-forge, we can probably have another go at this?

CC @ngam @hmaarrfk