conda-forge / pytorch_geometric-feedstock

A conda-smithy repository for pytorch_geometric.
BSD 3-Clause "New" or "Revised" License
6 stars 17 forks source link

pytorch_geometric v2.5.0 #36

Closed regro-cf-autotick-bot closed 7 months ago

regro-cf-autotick-bot commented 7 months ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
captum 0.7.0 Anaconda-Server Badge
scikit-learn 1.4.1.post1 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7928155606, please use this URL for debugging.

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mikemhenry commented 7 months ago

Looks good, upstream doesn't report any new deps or breaking changes

RaulPPelaez commented 7 months ago

This broke some of my feedstocks during testing: https://github.com/conda-forge/torchmd-net-feedstock/pull/21

import: 'torchmdnet'
import: 'torchmdnet'
+ pip check
torch-geometric 2.5.0 requires aiohttp, which is not installed.
WARNING: Tests failed for torchmd-net-0.15.2-cpu_py311h48312d8_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: torchmd-net-0.15.2-cpu_py311h48312d8_0.conda
RaulPPelaez commented 7 months ago

I overcame this by adding aiohttp to the run reqs, but I feel like that dependency should be listed here instead?

mikemhenry commented 7 months ago

sigh is aiohttp a new dep? I must have missed it in the changelog, happy to add it here if this is where it belongs :)

RaulPPelaez commented 7 months ago

Seems to be! I did not see it in the release page, though. Perhaps a dependency of a dependency? I would just add it to the run deps here.

mikemhenry commented 7 months ago

Fixed in https://github.com/conda-forge/pytorch_geometric-feedstock/pull/37