Closed RaulPPelaez closed 10 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This should also make CUDA 12 work when the bot opens it.
Thanks Raul! 🙏
Would it make sense to add the CUDA 12 migrator here too?
Yes, did not know that was a possibility hehe
@conda-forge-admin , please re-render
Yes, did not know that was a possibility hehe
Yep the logic is set up so that feedstocks can handle multiple migrators at once 🙂
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the rebuild-cuda118-0-1_hc91753 branch of RaulPPelaez/pytorch_sparse-feedstock. Did you check the "Allow edits from maintainers" box?
NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch_sparse-feedstock/actions/runs/7016608365.
Ah may need to re-render by hand or adjust the PR settings and ask the bot again
Re-rendering will add the remaining CUDA 12 CI jobs to the matrix
Thanks Raul! 🙏
Looks good 👍
One last thing we could do is drop these old skip
s. As CUDA 11.2 is the minimum in conda-forge ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/1708 ), these skip
s are now unneeded
The CUDA 12 builds are running into a bad pybind+gcc12+CUDA12 interaction. I tried to instruct the migrator to use gcc 11 instead: https://github.com/conda-forge/pytorch_sparse-feedstock/pull/58/commits/95f38a176303c25553b3e2469fb81a86c53801db
But its not listening to me -.-
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the rebuild-cuda118-0-1_hc91753 branch of RaulPPelaez/pytorch_sparse-feedstock. Did you check the "Allow edits from maintainers" box?
NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch_sparse-feedstock/actions/runs/7188226459.
There was a new release ( https://github.com/conda-forge/pytorch_sparse-feedstock/pull/60 ), which might play better with CUDA 11.8
Tried to ask the bot to re-render, but it looks like maintainer edits would need to be enabled
Alternatively could re-render manually
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the rebuild-cuda118-0-1_hc91753 branch of RaulPPelaez/pytorch_sparse-feedstock. Did you check the "Allow edits from maintainers" box?
NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch_sparse-feedstock/actions/runs/7191763992.
Weird! the "Allow edits" box wa already checked. The CUDA 12 migrator did not have the use_local: true flag, which was the root of the issue. I updated and rerendered, should be fine now.
The CUDA 12 migrator did not have the use_local: true flag, which was the root of the issue. I updated and rerendered, should be fine now.
Huh weird. Thought I posted about that here somewhere, but don't see it. Sorry about that 😞
Edit: It was in the bot PR ( https://github.com/conda-forge/pytorch_sparse-feedstock/pull/62#discussion_r1424667276 ) 🤦♂️
Everything build, ready to merge on my side. This also includes #62 and #59, so three birds in one stone.
Looks good. Thanks Raul 🙏
@mikemhenry when you have a chance, could you please review? 🙂
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the rebuild-cuda118-0-1_hc91753 branch of RaulPPelaez/pytorch_sparse-feedstock. Did you check the "Allow edits from maintainers" box?
NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch_sparse-feedstock/actions/runs/7429228333.
Want to make sure we have fresher results (even though it passed some weeks ago)
@conda-forge-admin , please restart CI
Friendly nudge @mikemhenry 😉
@h-vetinari would you have a moment to look at this one?
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This is just #57 but with the missing archs added Closes #62 Closes #59