conda-forge / qgis-feedstock

A conda-smithy repository for qgis.
BSD 3-Clause "New" or "Revised" License
41 stars 26 forks source link

Update QGIS stable branch to 3.34.0 Release candidate #377

Closed SrNetoChan closed 8 months ago

SrNetoChan commented 8 months ago

Future LTR branch in February

Checklist

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

SrNetoChan commented 8 months ago

@conda-forge-admin, please rerender

gillins commented 8 months ago

@h-vetinari any ideas on why we are getting failures with protobuf on osx-arm64 now? Seems to be picking up the wrong binaries...

h-vetinari commented 8 months ago

@h-vetinari any ideas on why we are getting failures with protobuf on osx-arm64 now? Seems to be picking up the wrong binaries...

Rather than deleting the "wrong" protoc https://github.com/conda-forge/qgis-feedstock/blob/100a818dd5e81807c1f42f40e215e23c597334f0/recipe/build.sh#L46-L47

you should be setting -DProtobuf_PROTOC_EXECUTABLE=$BUILD_PREFIX/bin/protoc

h-vetinari commented 8 months ago

If you still run into troubles even so, you might need to do something like https://github.com/conda-forge/opencv-feedstock/commit/bbe46049a19e30c96cadbdf07affcaf0b8c6230d, c.f. also https://github.com/protocolbuffers/protobuf/issues/14576

gillins commented 8 months ago

Done in #380

gillins commented 8 months ago

Thanks for the tips @h-vetinari ! Got it running in the end.