conda-forge / qgis-feedstock

A conda-smithy repository for qgis.
BSD 3-Clause "New" or "Revised" License
41 stars 26 forks source link

upload to LTR builds qgis_ltr label #430

Closed gillins closed 1 month ago

gillins commented 1 month ago

Checklist

Fixes https://github.com/conda-forge/qgis-feedstock/issues/425.

@ocefpaf is this what you meant?

Do I have to add a conda config --env --add channels qgis_ltr to the post install? Or is that not necessary?

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 1 month ago

@conda-forge-admin, please rerender

gillins commented 1 month ago

@conda-forge-admin, please restart ci.

gillins commented 1 month ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/qgis-feedstock/actions/runs/9073800104.

ocefpaf commented 1 month ago

@ocefpaf is this what you meant?

Yep.

Do I have to add a conda config --env --add channels qgis_ltr to the post install? Or is that not necessary?

That is not needed. The error here is unrelated to the PR. Something broken in the CIs configuration but I believe it was already fixed. Restarting the CIs here to check.

gillins commented 1 month ago

Thanks @ocefpaf. Looks all good now. How will we publicize this change?

Are you happy with this @SrNetoChan @petrushy ?

petrushy commented 1 month ago

Many thanks! Looks good!

ocefpaf commented 1 month ago

How will we publicize this change?

I guess that is the hardest part. We do have a blog for announcements but I doubt that will reach qgis conda users.

SrNetoChan commented 1 month ago

What's the difference? How do we install qgis ltr now? I can update my blog post about it. I also wanted to add conda installation procedure on qgis website, maybe that's the perfect time for it.

SrNetoChan commented 1 month ago

Will it be?

conda install -c conda-forge/label/qgis_ltr qgis ?

How about the update procedure? We will need to add the channel again?

conda update -conda-forge/label/qgis_ltr qgis

Is there a way make qgis_ltr label the default for and environment?

This means that if I want to install a particular version of QGIS, that happens to have been a LTR, I will need to know it beforehad, otherwise it won't be available using the normal install (main label)?

ocefpaf commented 1 month ago

Will it be?

conda install -c conda-forge/label/qgis_ltr qgis ?

That should work but I prefer,

conda install conda-forge/label/qgis_ltr::qgis

because it mimics how one adds it to an environment.yaml file.

However, I'm not sure that works in all conda's flavors, like micromamba, etc. So maybe it is safer to stick with your CLI there.

How about the update procedure? We will need to add the channel again?

conda update -conda-forge/label/qgis_ltr qgis

That should work.

Is there a way make qgis_ltr label the default for and environment?

Yes, one can add that to a .condarc. Something like:

channels:
  - conda-forge/label/qgis_ltr
  - conda-forge

Should ensure that the LTR is preffered over the version in the main channel.

This means that if I want to install a particular version of QGIS, that happens to have been a LTR, I will need to know it beforehad, otherwise it won't be available using the normal install (main label)?

Yes. You need to search, install, etc from the LTR label. A label is like a channel, just a trick to keep it under the same org name.

gillins commented 1 month ago

@SrNetoChan - merge this if/when you are happy

SrNetoChan commented 1 month ago

I have no strong feelings about this. But if others feel it's useful, why not? I wonder if we could/should add this conda-forge/label/qgis_ltr line in our post-install process. That way, from that point on, the update would be in line with the "normal" install.

Sent with Shortwave https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=c2VuaG9yLm5ldG9AZ21haWwuY29t

On Thu May 16, 2024, 04:52 AM GMT, Sam Gillingham @.***> wrote:

@SrNetoChan https://github.com/SrNetoChan - merge this if/when you are happy — Reply to this email directly, view it on GitHub https://github.com/conda-forge/qgis-feedstock/pull/430#issuecomment-2114024190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3QU6KT3GEAN632J67INCLZCQ3QXAVCNFSM6AAAAABHTMYKZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJUGAZDIMJZGA. You are receiving this because you were mentioned.Message ID: @.***>

SrNetoChan commented 1 month ago

Although, can the .condarc be edited for a specific environment?

SrNetoChan commented 1 month ago

I guess this answers it:

https://stackoverflow.com/a/51747791

SrNetoChan commented 1 month ago

I am merging this. Let's see how it works. Thanks @gillins and @ocefpaf

SrNetoChan commented 1 month ago

Ok. This worked pretty well. I did it this way:

mamba create -n qgis_ltr
mamba activate qgis_ltr
conda config --env --add channels conda-forge/label/qgis_ltr
mamba install qgis

the qgis packages was picked from the qgis_ltr label and all the rest from conda-forge.

petrushy commented 1 month ago

Works very well, I removed the qgis, added conda config --env --add channels conda-forge/label/qgis_ltr and got the ltr version as expected.

Now conda update --all works (keeps the LTR version).

Many thanks for this feature!