Add run_exports - Githubissues

conda-forge / qhull-feedstock

A conda-smithy repository for qhull.

BSD 3-Clause "New" or "Revised" License

3 stars 10 forks source link

Add run_exports #14

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

The run_exports directive has been missing, which can lead to problems downstream (see https://github.com/RoboStack/ros-noetic/issues/97). I am not sure about the ABI compatibility, so I was conservative with a x.x pin.

/cc @traversaro - thanks for pointing this out.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@Sirokujira - this is ready to be merged.

Tobias-Fischer commented 3 years ago

Superseded by #15