Fix OSX rpath + add run_exports

conda-forge / qhull-feedstock

A conda-smithy repository for qhull.

BSD 3-Clause "New" or "Revised" License

3 stars 10 forks source link

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

So in the original log (master branch), this line appears:

2021-03-09T08:32:36.2027170Z Don't know how to find lib/libqhull_r.8.0.dylib, skipping

This line disappears after applying the patch in this PR. However, locally I tried and the same error as described in https://github.com/RoboStack/ros-noetic/issues/97 still occurs.

Any clue?

/cc @wxmerkt @wolfv @traversaro

Tobias-Fischer commented 3 years ago

I was wrong - indeed this PR does fix the rpath issues on OSX (I needed to uninstall+re-install qhull on my local machine).

@Sirokujira this is ready to be merged

/cc @wolfv @wxmerkt @traversaro

Tobias-Fischer commented 3 years ago

I included #14 in this PR so we don't need multiple merges.