Fix export of symbols on Windows

conda-forge / qhull-feedstock

A conda-smithy repository for qhull.

BSD 3-Clause "New" or "Revised" License

3 stars 10 forks source link

Fix export of symbols on Windows #16

Closed jcarpent closed 3 years ago

jcarpent commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jcarpent commented 3 years ago

@wolfv This PR is ready for review. Thanks in advance.

jcarpent commented 3 years ago

@conda-forge/help-c-cpp This PR is ready for review and merging

jcarpent commented 3 years ago

@Sirokujira Would you have time to review this PR?

jcarpent commented 3 years ago

@xhochy Will you have to review this PR? Thanks in advance.

xhochy commented 3 years ago

Wouldn't it be more viable to auto-generate this file like we do in r-base https://github.com/conda-forge/r-base-feedstock/blob/e74584ad023e552247fc9451a6ce2e576be2b439/recipe/bld-r-base.bat#L52 ?

jcarpent commented 3 years ago

Wouldn't it be more viable to auto-generate this file like we do in r-base https://github.com/conda-forge/r-base-feedstock/blob/e74584ad023e552247fc9451a6ce2e576be2b439/recipe/bld-r-base.bat#L52 ?

Here the situation is a bit different, in the sense that the .def file is used to export the DLL.