Reactivate static libs - Githubissues

conda-forge / qhull-feedstock

A conda-smithy repository for qhull.

BSD 3-Clause "New" or "Revised" License

3 stars 10 forks source link

Reactivate static libs #19

Closed ymontmarin closed 2 months ago

ymontmarin commented 2 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

If there is no fundamental needs of disabling the statics libs, this PR only reactivate it to solve: https://github.com/conda-forge/qhull-feedstock/issues/18 and in turn allow package that use qhull at build time to compile again (see e.g. https://github.com/conda-forge/hpp-pinocchio-feedstock/pull/29)

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ymontmarin commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/qhull-feedstock/actions/runs/9854924406.

ymontmarin commented 2 months ago

@xhochy I think it is ready to merge, if it is ok to re-activate de statics libs for downstream package requiring qhull at build time :)

ymontmarin commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/qhull-feedstock/actions/runs/9891810350.

ymontmarin commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/qhull-feedstock/actions/runs/9892041446.

xhochy commented 2 months ago

@ymontmarin If you're a bit patient, I can build an alternative later today that separate the dynamic lib out and changes the run_exports.

ymontmarin commented 2 months ago

@xhochy Sorry, I have been a bit messy in my commits, but this looks to work and be ready for merge. I believe it follows the CFEP 18.

However, if you have any enhancement suggestion I can be patient, of course :)

jorisv commented 2 months ago

The qhull-static package only contains info directory. When adding qhull-static as a dependency, the build is not working (missing Qhull::qhullcpp target).

I will recreate a PR to try to fix that.