search

conda-forge / qscintilla2-feedstock

A conda-smithy repository for qscintilla2.
BSD 3-Clause "New" or "Revised" License
0 stars 14 forks source link

Create Qt5 version #10

Closed gillins closed 7 years ago

gillins commented 7 years ago

This PR creates a Qt5 version of qscintilla2 necessary for new versions of qgis etc.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dschreij commented 7 years ago

I had the Qt5 build script working a while ago (https://github.com/conda-forge/qscintilla2-feedstock/tree/qt5), but I have had no instructions from the anaconda team on how to best integrate this on forge while keeping both Qt4 and 5 versions available. I assume the Qt4 pacakges should remain available too, so by merging this PR the build scripts for Qt4 will be lost. @conda-forge-admin, what is the best way to go at this? I raised this as an issue on this repo a while ago, but the discussion has died since then.

gillins commented 7 years ago

Apparently it is not possible to have both Qt4 and Qt5 installed at once (see https://github.com/conda-forge/qt-feedstock/issues/15#issuecomment-272603134). Since Qt4 is no longer supported it seems sensible to upgrade everything to Qt5 and just have the old builds for Qt4. @ccordoba12 and @ocefpaf may have more thoughts on this.

I had the Qt5 build script working a while ago

I hadn't seen that. Feel free to close this PR.

dschreij commented 7 years ago

I might as well merge your PR since it also passes the tests and my version is quite stale (I haven't tested it in quite a while).

dschreij commented 7 years ago

And thanks @gillins!

ocefpaf commented 7 years ago

Since Qt4 is no longer supported it seems sensible to upgrade everything to Qt5 and just have the old builds for Qt4.

That is pretty much it. We should upgraded everything we can to qt5.

dschreij commented 7 years ago

@ocefpaf Is anaconda still stuck at PyQt 5.6(.2), or has the team found a way around the lack of support by Riverbank for the compilers used for the conda environment?