add linux_aarch64 - Githubissues

conda-forge / qscintilla2-feedstock

A conda-smithy repository for qscintilla2.

BSD 3-Clause "New" or "Revised" License

0 stars 14 forks source link

add linux_aarch64 #37

Closed matthiasdiener closed 2 years ago

matthiasdiener commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [13]
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [53]

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthiasdiener commented 2 years ago

This is ready for review @conda-forge/qscintilla2

matthiasdiener commented 2 years ago

A gentle ping for review @conda-forge/qscintilla2 @conda-forge/core

dschreij commented 2 years ago

I am too unfamiliar on the architecture matters since I haven't worked with conda for a while. I can merge this after a very shallow review, but I don't think that's desirable

wolfv commented 2 years ago

Looks good to me!

dschreij commented 2 years ago

Thanks @matthiasdiener and @wolfv