Closed matthiasdiener closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
py
. For example: # [py>=36]
. See lines [13]Documentation on acceptable licenses can be found here.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
<two spaces>#<one space>[<expression>]
form. See lines [53]Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This is ready for review @conda-forge/qscintilla2
A gentle ping for review @conda-forge/qscintilla2 @conda-forge/core
I am too unfamiliar on the architecture matters since I haven't worked with conda for a while. I can merge this after a very shallow review, but I don't think that's desirable
Looks good to me!
Thanks @matthiasdiener and @wolfv
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)