conda-forge / qscintilla2-feedstock

A conda-smithy repository for qscintilla2.
BSD 3-Clause "New" or "Revised" License
0 stars 14 forks source link

try add osx_arm64 build #48

Closed SrNetoChan closed 1 year ago

SrNetoChan commented 1 year ago

Checklist

This is necessary for building QGIS in osx_arm64 and linux_aarch64 https://github.com/conda-forge/qgis-feedstock/pull/289

SrNetoChan commented 1 year ago

Hurrey!!!!

@hmaarrfk and @gillins thanks for all your help. I have learned quite a lot.

See if the build.sh change could be made in another way, the repeated code looks ugly.

hmaarrfk commented 1 year ago

Great work! Sorry I didn't want to invoke CFEP03. I think this way you are more empowered to move at your speed in the future!

SrNetoChan commented 1 year ago

Great work! Sorry I didn't want to invoke CFEP03. I think this way you are more empowered to move at your speed in the future!

Definitely better this way, as it fixes it for good. I wonder if native arm compiling will be available in the future.

hmaarrfk commented 1 year ago

Why not cross compile linux-aarch64 too? it is "faster" and can be a good quality of life improvement for future versions.

SrNetoChan commented 1 year ago

Since you said it was complicated and it worked natively... No strong feelings about it.

hmaarrfk commented 1 year ago

oh but you fixed things! you went through the complications!

SrNetoChan commented 1 year ago

In that case, let's move it back to cross compiling also for linux, so it's much faster.

gillins commented 1 year ago

Thanks @SrNetoChan ! That was an inspired bit work. Is this ready to merge yet, or do you need to make the Linux cross compiling change?

SrNetoChan commented 1 year ago

Well lets follow @hmaarrfk advice and make it faster to compile

SrNetoChan commented 1 year ago

@conda-forge-admin, please rerender

SrNetoChan commented 1 year ago

@gillins the change is done, you can add that tag that allows to merge if all checks are good. it shouldn't take long tho.

gillins commented 1 year ago

I'm not a maintainer on this feedstock so will have to wait for @conda-forge/qscintilla2 to merge for us - I think it's all good to go now - thanks!

hmaarrfk commented 1 year ago

given your intimate knowledge of the package ,you might want to ask to be a maintainer too.

SrNetoChan commented 1 year ago

@ocefpaf could you please merge this one?

SrNetoChan commented 1 year ago

@conda-forge-admin, please ping team

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/qscintilla2 and so here I am doing that.

gillins commented 1 year ago

@SrNetoChan do you want to add yourself as a maintainer as part of this PR?

SrNetoChan commented 1 year ago

Not sure how active I will be able to be, and... I really don't know what I am doing :-)

SrNetoChan commented 1 year ago

I have add myself as maintainer.

matthiasdiener commented 1 year ago

@conda-forge-admin, please rerender

SrNetoChan commented 1 year ago

@matthiasdiener I forgot to rerender. thanks!

SrNetoChan commented 1 year ago

@matthiasdiener can you please merge it. I don't have permissions for that.