BUG add ld64 - Githubissues

beckermr commented 4 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 4 years ago

This change was needed to build qt locally on my mac. I am adding it here for posterity.

beckermr commented 4 years ago

@isuruf can you take a look?

We don't need a build number bump here.

mingwandroid commented 4 years ago

Why isn't this getting pulled in as a dependency of the compiler?

beckermr commented 4 years ago

Good question.

beckermr commented 4 years ago

Here is the build env w/ ld64

    cctools_osx-64:     949.0.1-h5ba7a2e_7        conda-forge
    clang:              10.0.1-default_hf57f61e_1 conda-forge
    clang_osx-64:       10.0.1-h05bbb7f_8         conda-forge
    clangxx:            10.0.1-default_hf57f61e_1 conda-forge
    clangxx_osx-64:     10.0.1-h05bbb7f_8         conda-forge
    compiler-rt:        10.0.1-he6db49b_0         conda-forge
    compiler-rt_osx-64: 10.0.1-h033240e_0         conda-forge
    ld64:               530-7                     conda-forge
    ld64_osx-64:        530-h3c32e8a_7            conda-forge
    libclang-cpp10:     10.0.1-default_hf57f61e_1 conda-forge
    libcxx:             10.0.1-h5f48129_0         conda-forge
    libiconv:           1.16-haf1e3a3_0           conda-forge
    libllvm10:          10.0.1-h009f743_3         conda-forge
    llvm-tools:         10.0.1-h1341992_3         conda-forge
    make:               4.3-h0b31af3_0            conda-forge
    ninja:              1.10.1-h879752b_1         conda-forge
    perl:               5.30.3-h6156909_1         conda-forge
    pkg-config:         0.29.2-hdc84dc8_1006      conda-forge
    tapi:               1000.10.8-h879752b_4      conda-forge
    zlib:               1.2.11-h7795811_1009      conda-forge

and here it is without

    cctools_osx-64:     949.0.1-h5ba7a2e_7        conda-forge
    clang:              10.0.1-default_hf57f61e_1 conda-forge
    clang_osx-64:       10.0.1-h05bbb7f_8         conda-forge
    clangxx:            10.0.1-default_hf57f61e_1 conda-forge
    clangxx_osx-64:     10.0.1-h05bbb7f_8         conda-forge
    compiler-rt:        10.0.1-he6db49b_0         conda-forge
    compiler-rt_osx-64: 10.0.1-h033240e_0         conda-forge
    ld64_osx-64:        530-h3c32e8a_7            conda-forge
    libclang-cpp10:     10.0.1-default_hf57f61e_1 conda-forge
    libcxx:             10.0.1-h5f48129_0         conda-forge
    libiconv:           1.16-haf1e3a3_0           conda-forge
    libllvm10:          10.0.1-h009f743_3         conda-forge
    llvm-tools:         10.0.1-h1341992_3         conda-forge
    make:               4.3-h0b31af3_0            conda-forge
    ninja:              1.10.1-h879752b_1         conda-forge
    perl:               5.30.3-h6156909_1         conda-forge
    pkg-config:         0.29.2-hdc84dc8_1006      conda-forge
    tapi:               1000.10.8-h879752b_4      conda-forge
    zlib:               1.2.11-h7795811_1009      conda-forge

IDK the difference between ld64 and ld64_osx-64 or what having both in one env will do.

mingwandroid commented 4 years ago

ld64_osx-64 should depend on ld64 I think!

beckermr commented 4 years ago

I only see a dependence on ld which I cannot actually find as a package anywhere...

isuruf commented 4 years ago

ld64_osx-64 has only the prefixed tools like x86_64-apple-darwin13.4.0-ld. ld64 has ld64_osx-64 as a run requirement, but also has ld->x86_64-apple-darwin13.4.0-ld symlink. I think we can add ld64 package to clang_osx-64 when it's a native compiler.

isuruf commented 4 years ago

Issue here is that qt is using clang instead of x86_64-apple-darwin13.4.0-clang. Only the latter knows to use x86_64-apple-darwin13.4.0-ld while the former only looks for ld.

beckermr commented 4 years ago

I think we can add ld64 package to clang_osx-64 when it's a native compiler.

Cool. See here: https://github.com/conda-forge/clang-compiler-activation-feedstock/pull/34

I am going to close this PR assuming the change to clang gets merged.

conda-forge / qt-feedstock

BUG add ld64 #170