search

conda-forge / qt-feedstock

A conda-smithy repository for qt.
BSD 3-Clause "New" or "Revised" License
12 stars 57 forks source link

Test run Qt 5.15 #198

Closed andfoy closed 3 years ago

andfoy commented 3 years ago

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

andfoy commented 3 years ago

@conda-forge-admin, please re-render

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

andfoy commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

andfoy commented 3 years ago

@conda-forge-admin, please rerender

andfoy commented 3 years ago

The PR is failing due to missing tests, which tests do you suggest here @isuruf @ccordoba12?

ccordoba12 commented 3 years ago

There are some tests already on this feedstock. Please try to reuse them for qt-main.

isuruf commented 3 years ago

There are some tests already on this feedstock. Please try to reuse them for qt-main.

Yes, please try to keep the diff as minimal as possible so that it's easy to review.

andfoy commented 3 years ago

@isuruf, is it possible to re-run the aarch64 job somehow? It always get killed about the hour mark.

Tobias-Fischer commented 3 years ago

Drone has a one hour time limit. You can try switching provider to azure for linux_aarch64: https://conda-forge.org/docs/maintainer/conda_forge_yml.html#provider (needs rerender)

isuruf commented 3 years ago

We can't do aarch64 on CI. Switching to Azure is not going to work either.

andfoy commented 3 years ago

We can't do aarch64 on CI. Switching to Azure is not going to work either.

This means that we will need to upload packages by hand?

isuruf commented 3 years ago

This means that we will need to upload packages by hand?

Yes, we can worry about that later. Let me know after you've reduced the diff and I can review.

andfoy commented 3 years ago

The recipe is working here as well, including tests, I guess is now ready for review. Since we are now using CentOS 7 for compiling in Linux, all the glibc patches are not required anymore. Also, the removal of qtwebengine implies that most of the hacks and tricks that were previously used are now removed.

isuruf commented 3 years ago

I'm not going to review a complete rewrite that discards away all the knowledge that we gained over the years. Please reduce the diff and if you are changing something please make a comment or a commit message with the reason why it was done.

izahn commented 3 years ago

I'm sad to see this effort apparently stall out. Is there anything I can do to help? Although I don't have an interest in QT itself I would love to see QT 5.15 in conda-forge so we can update qgis

andfoy commented 3 years ago

@izahn, right now I was taking some time off, but we'll resume this work as soon as possible.

SrNetoChan commented 3 years ago

Long story short, It seem that QT Co. has abandoned Qt5 development and maintenance moving all the way to Qt6, which means no more bug fixes on qt5. Meanwhile, KDE has forked qt5 branch and applying fixes there. Fedora is also using this fork. Debian seems to have decided that it will apply just some necessary patches.

Is there any plans on using and alternative fork?

andfoy commented 3 years ago

Closing in favor of https://github.com/conda-forge/qt-feedstock/pull/206