Closed hmaarrfk closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin please rerender
Not sure why it isn't picking up the patched version. We can try again tomorrow.
@conda-forge/qt-main @conda-forge/qt this is ready for review.
5.15.3 will have to wait for: https://github.com/conda-forge/qt-webengine-feedstock/pull/5
@conda-forge/qt can we get a review here? We've been waiting a long time for qt=5.15
, and several packages need it before they can be updated.
https://github.com/orgs/conda-forge/teams/qt can we get a review here? We've been waiting a long time for qt=5.15, and several packages need it before they can be updated.
We'll probably not use qt
as the package just like we don't use matplotlib
and just use matplotlib-base
.
Please send a PR to the bot to add a migrator to change qt
to qt-main
in recipes.
We'll probably not use
qt
as the package just like we don't usematplotlib
and just usematplotlib-base
.Please send a PR to the bot to add a migrator to change
qt
toqt-main
in recipes.
I've never done this before, and it looks like name migrations are rare. Is there an example I can look at? Or maybe someone with more experience can handle this one.
Here is an example: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/matplotlib_base.py and some documentation is here: https://regro.github.io/cf-scripts/migrators.html#custom-migrations
But it looks like this one is more complicated than it should be because something went wrong during the migration and half of the file is about the fix of that rather than the actual migration ..
Here is an example: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/matplotlib_base.py and some documentation is here: https://regro.github.io/cf-scripts/migrators.html#custom-migrations
But it looks like this one is more complicated than it should be because something went wrong during the migration and half of the file is about the fix of that rather than the actual migration ..
Oh my, yeah, this looks like it needs attention from someone with more experience with migrations then I have.
Hi @beckermr - sorry to bother you, but do you have an idea how we can handle the migration from qt 5.12
to qt-main 5.15
? It seems like it's going beyond the expertise of most of us, there doesn't seem to be an example that can be easily adapted (the matplotlib
one I linked above does a rename but no version bump, and contains some code fixing a broken migration) and you seem to be very active in https://github.com/regro/cf-scripts/tree/master/conda_forge_tick/migrators so I thought I'd reach out.
You need to write a mini-migrator that changes qt to qt-main and add that as a piggy-back migrator in the version migration at https://github.com/regro/cf-scripts/blob/64c14692b14cf07655b65d01ec8fd75649e56ac5/conda_forge_tick/auto_tick.py#L661. Then, you start a regular migration yaml like https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/icu70.yaml. A sample mini-migrator is at https://github.com/regro/cf-scripts/blob/64c14692b14cf07655b65d01ec8fd75649e56ac5/conda_forge_tick/migrators/cross_compile.py#L37
Here is my attempt:
https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/2929
Should we update this PR to use 5.15.3 instead, now that https://github.com/conda-forge/qt-webengine-feedstock/pull/5 is merged?
Having both versions wouldn't be a bad idea. we can deal with that later. Some stuff is still on ICU69. Seeing as this package is now trivial, it isn't a big deal.
I think that for now, we should keep this as an arch dependent package so we can test that compilation works for all packages
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)