Update version - Githubissues

conda-forge / qt-feedstock

A conda-smithy repository for qt.

BSD 3-Clause "New" or "Revised" License

12 stars 57 forks source link

Update version #230

Closed hmaarrfk closed 2 years ago

hmaarrfk commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

I think some old environment are failing to "update" because qt is at version 5.15.2 but their packages requires some migrations that are only available with 5.15.3 (which is why I was really adamant about holding off on 5.15.3 during the initial rollout).

I'm not sure if there is a way we can tell conda to forget about the qt, and replace with qt-main. But that seems hard.

Instead, I think we should make it an error to depend on qt in any new recipe, that way people get the correct pinnings.

jakirkham commented 2 years ago

Could add a lint to conda-smithy

hmaarrfk commented 2 years ago

???

jakirkham commented 2 years ago

Sorry for the lack of clarity, was responding to this last line

Instead, I think we should make it an error to depend on qt in any new recipe, that way people get the correct pinnings.

We have a number of lints/hints starting here. For example this pip hint could be a good starting point for a qt related lint (or hint)