qt does not link to conda libs (libjpeg, libtiff)

conda-forge / qt-main-feedstock

A conda-smithy repository for qt-main.

BSD 3-Clause "New" or "Revised" License

5 stars 29 forks source link

qt does not link to conda libs (libjpeg, libtiff) #124

Open jschueller opened 4 years ago

jschueller commented 4 years ago

qt imageformats plugins do not link

to libjpeg as qt wants libjpeg-turbo (it checks for jpeg_crop_scanline, needed for chromium 3rd party) the bad news is that conda forge wont switch anytime soon: https://github.com/conda-forge/conda-forge.github.io/issues/673
to libtiff (depends on libjpeg), worse it links to ImageIO's framework on osx (libTIFF.dylib)

hmaarrfk commented 3 years ago

i don't think we are against moving to turbo, but we are just slow since it seems involved. your help would be greatly apprecaited moving to turbo.

traversaro commented 3 years ago

* to libjpeg as qt wants libjpeg-turbo (it checks for jpeg_crop_scanline, needed for chromium 3rd party)
  the bad news is that conda forge wont switch anytime soon:
  [conda-forge/conda-forge.github.io#673](https://github.com/conda-forge/conda-forge.github.io/issues/673)

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

isuruf commented 3 years ago

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

No. We can either switch to jpeg-turbo or not at all. Nothing in the middle please.

traversaro commented 3 years ago

Even if conda-forge does not globally switch to jpeg-turbo, I think it can work fine if any port that requires it just depends on jpeg-turbo .

No. We can either switch to jpeg-turbo or not at all. Nothing in the middle please.

Sorry, I meant that I recalled that there are some port already depended on jpeg-turbo, see https://github.com/search?l=YAML&q=org%3Aconda-forge+libjpeg-turbo&type=Code . If this is not support/discouraged, probably it should be documented somewhere?

isuruf commented 3 years ago

If this is not support/discouraged

Yes, it is not supported and discouraged.

probably it should be documented somewhere?

We are all volunteers here. PRs to docs are welcome.

traversaro commented 3 years ago

probably it should be documented somewhere?

We are all volunteers here. PRs to docs are welcome.

Sure! I just explained why I had no idea depending on libjpeg-turbo was not supported and discouraged, not complaining that it was not documented anywhere.

isuruf commented 3 years ago

libjepg and libjpeg-turbo have common symbols and loading both into the same process can be problematic. This is the same situation with MKL and openblas where we also discourage having both in the same env.

hmaarrfk commented 3 years ago

I remember one thing that was brought up was that qt isn't easy to build. With the speed at which all the dependencies are released on conda forge, it would be a large maintenance burden to depend on too many things.

hmaarrfk commented 5 months ago

In 2024, we now link to jpeg-turbo but not to libtiff, we can likely address this now that much of the infrastructure has been cleaned up.