Closed regro-cf-autotick-bot closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Ah damn, I didn't realize this was outstanding still, otherwise I would have proposed to include it in #15.
However, I think we could just undo the build number bump and rebuild only the openssl3 versions?
Thoughts @hmaarrfk @Tobias-Fischer @pkgw ?
Ummm. yeah. lets undo the build number bump. Somebody would have to build windows. I can't.
This seems to be a windows only migration.
This seems to be a windows only migration.
Interesting. That's because openssl has a # [win]
selector. Seems I got confused because https://github.com/conda-forge/rstudio-feedstock/pull/13 still runs into resolver errors on linux/osx when trying to use OpenSSL 3, but those seem to be due to a nodejs/icu pin after all.
So I think openssl might not be necessary even on windows?
Looking at the windows build logs from #15, I see:
WARNING (qt-webengine): run-exports library package conda-forge::openssl-1.1.1s-hcfcfb64_1 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
This is perhaps unsurprising, because in the vendored chromium, we find:
%SRC_DIR%\src\3rdparty\chromium\third_party\boringssl\src\include\openssl/base.h(176): warning C4005: 'OPENSSL_VERSION_NUMBER': macro redefinition
%PREFIX%\Library\include\openssl/opensslv.h(42): note: see previous definition of 'OPENSSL_VERSION_NUMBER'
do you have a windows machine to test things on?
One app i know uses qt-webengine is spyder
. You can likely use --force
to install things.
do you have a windows machine to test things on?
I think we could just remove - openssl # [win]
either here or in #20 and see if the CI fails. Otherwise I might be able to do something next weekend.
BTW, I traced that dep all the way back to the original feedstock PR, and it's not obvious to me why it was added. Perhaps @andfoy still remembers?
@conda-forge-admin please rerender
I might not be able to kick it off today, but I should be able to launch a test Windows build pretty soon, if needed.
OK, I was able to successfully build https://github.com/conda-forge/qt-webengine-feedstock/pull/19/commits/4a65ef5f578f4f4f6e9bc9e2fa741e4323504bbe. So ... if the latest Windows packages don't actually depend on OpenSSL even though they were included as a dep, I think that we could merge this and just patch the metadata for the existing packages. But I think we'd want to verify that the existing packages actually work when OpenSSL is either not installed or the 3.x version is.
, I think that we could merge this and just patch the metadata for the existing packages
I hate writing those patches, i feel like it would be easier to upload your new package tbh.
That's very reasonable, and the build has a different hash, so the package is distinct.
Package: https://anaconda.org/pkgw-forge/repo/files?type=any&label=cfep03-noopenssl
Build log: win64.log.zip
@hmaarrfk Are you able to do the CFEP-03 upload for this?
done.
This PR has been triggered in an effort to update openssl3.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3664959955, please use this URL for debugging.